…orQueueConfigMapName

Add five package-level constants and one exported naming function to
support the ConfigMap-based ingestor queue configuration delivery:

- ingestorQueueConfigAppName: Splunk app directory "100-sok-ingestorcluster"
- ingestorQueueConfigTemplateStr: ConfigMap name pattern "splunk-<name>-ingestor-queue-config"
- ingestorQueueConfigRevAnnotation: pod annotation key "ingestorQueueConfigRev"
- ingestorQueueConfigMountPath: "/mnt/splunk-queue-config"
- commandForIngestorQueueConfig: init container bash command (mkdir + ln -sfn + cp local.meta)
- GetIngestorQueueConfigMapName(crName): formats ConfigMap name

CSPL-4554

…ecksum for queue config

Add five pure functions to build the ConfigMap content for the ingestor
queue configuration app. These functions are side-effect-free and called
by buildAndApplyIngestorQueueConfigMap in the next commit.

- computeIngestorConfChecksum: SHA-256 of outputsConf+defaultModeConf
  stored in local.meta [app/install] so Splunk detects content changes
- generateIngestorOutputsConf: builds outputs.conf reusing
  getQueueAndObjectStorageInputsForIngestorConfFiles; embeds credentials
  when non-empty (same pattern as GetSmartstoreVolumesConfig)
- generateIngestorDefaultModeConf: builds default-mode.conf reusing
  getPipelineInputsForConfFile(false)
- generateIngestorAppConf: builds app.conf with state=enabled
- generateIngestorLocalMeta: builds local.meta with system access +
  install_source_checksum stanza

CSPL-4554

Build and idempotently apply the ingestor queue config ConfigMap on every
reconcile. splctrl.ApplyConfigMap is the idempotency gate — it skips the
write and returns (false, nil) when content is unchanged, so no extra work
is done on no-op reconciles triggered by the controller watches.

- Takes resolved QueueOSConfig (Queue, OS, AccessKey, SecretKey)
- Builds all four ConfigMap keys using the INI builder functions
- Sets owner reference so ConfigMap is GC'd with the IngestorCluster CR
- Returns (changed bool, error) matching splctrl.ApplyConfigMap signature

CSPL-4554

…orStatefulSet

Add the init container that pre-delivers queue config files before Splunk
starts, enabling zero-restart first-boot configuration (CSPL-4553).

setupIngestorInitContainer:
- Adds ConfigMap volume (mnt-splunk-queue-config) to the pod spec
- Appends init-ingestor-queue-config init container with the same security
  context as the existing setupInitContainer (runAsUser=41812, drop ALL,
  SeccompProfileTypeRuntimeDefault)
- Mounts /opt/splk/etc (etc PVC or ephemeral) + ConfigMap at mount path
- Runs commandForIngestorQueueConfig: mkdir + ln -sfn (conf files) + cp local.meta
  (cp not ln -sfn: Splunk replaces metadata symlinks with regular files)
- Sets ingestorQueueConfigRev pod annotation to ConfigMap ResourceVersion so
  the Restart EPIC detects content changes and triggers a rolling restart

getIngestorStatefulSet updated to call setupIngestorInitContainer after
setupAppsStagingVolume.

CSPL-4553

…figMap, remove REST path

Replace the PhaseReady credential-comparison/REST-update/RestartSplunk
flow with unconditional ConfigMap delivery on every reconcile. Controller
watches (Queue CR, ObjectStorage CR, Secret) and splctrl.ApplyConfigMap's
idempotency gate together ensure correctness without polling logic.

ApplyIngestorCluster:
- Add ResolveQueueAndObjectStorage + buildAndApplyIngestorQueueConfigMap
  calls before getIngestorStatefulSet (runs on every reconcile)
- Remove scale-up reset block that set CredentialSecretVersion="0"
- PhaseReady block no longer has secretChanged/serviceAccountChanged
  comparison or REST update/restart path

Removed entirely:
- ingestorClusterPodManager struct
- newIngestorClusterPodManager var
- getClient method
- updateIngestorConfFiles method
- getQueueAndPipelineInputsForIngestorConfFiles wrapper

Removed imports: go-logr/logr, splunk/client (splclient)
(splutil, splctrl, splcommon still used by remaining code)

ingestorcluster_test.go: remove REST-path mock block from
TestApplyIngestorCluster; remove TestGetQueueAndPipeline* and
TestUpdateIngestorConfFiles functions; remove addRemoteQueueHandlers
and newTestIngestorQueuePipelineManager helpers; remove now-unused
imports (fmt, net/http, strings, logr, splclient, splcommon).

CSPL-4556 CSPL-4553

… update fixtures

Replace REST-path mock-based tests with ConfigMap delivery tests.

ingestorcluster_test.go:
- TestApplyIngestorCluster: remove REST mock setup (newIngestorClusterPodManager
  override, addRemoteQueueHandlersForIngestor, HTTP handler setup); the second
  reconcile is now a plain ApplyIngestorCluster call — no HTTP mocks needed
- TestGetIngestorStatefulSet: switch from configTester to configTester2 (no
  space-stripping) because the bash init container command contains meaningful
  spaces; configTester's strings.ReplaceAll was mangling the command string
- Add TestComputeIngestorConfChecksum: 64-char hex, deterministic, content-sensitive
- Add TestGenerateIngestorOutputsConf: IRSA (no creds), static creds embedded
- Add TestGenerateIngestorDefaultModeConf: all 6 pipeline stanzas present
- Add TestGenerateIngestorAppConf: required stanzas present
- Add TestGenerateIngestorLocalMeta: checksum and export stanzas present
- Remove imports: fmt, net/http, strings, logr, splclient, splcommon
  (splutil, spltest, assert, appsv1/corev1/metav1 still used)

Fixture files (all 4 statefulset_ingestor*.json):
- Regenerated with json.Marshal format (& as \u0026) for exact configTester2 match
- Add initContainers: init-ingestor-queue-config with bash command, security
  context matching setupInitContainer pattern, two volume mounts
- Add volume: mnt-splunk-queue-config ConfigMap volume

go test ./pkg/splunk/enterprise/... passes with no regressions.

CSPL-4555 CSPL-4556

Replace pod-by-pod REST calls with ClusterManager bundle push pattern,
mirroring the existing SmartStore indexes.conf delivery mechanism.

Changes:
- pkg/splunk/common/paths.go: add path constants for outputs.conf,
  inputs.conf, and default-mode.conf under manager-apps and mnt
- pkg/splunk/enterprise/names.go: add commandForCMSmartstoreAndQueue
  and setSymbolicLinkCmanagerWithQueue constants for extended symlink
  setup when queue config is present
- pkg/splunk/enterprise/util.go: preserve queue config keys in
  ApplySmartstoreConfigMap so CM reconcile does not overwrite them;
  extend resetSymbolicLinks to use queue-aware command when present
- pkg/splunk/enterprise/indexercluster.go: add applyIdxcQueueConfigToCM
  which writes outputs.conf/inputs.conf/default-mode.conf into the CM's
  smartstore ConfigMap and sets BundlePushTracker.NeedToPushManagerApps;
  add generateIdxcOutputsConf/InputsConf/DefaultModeConf INI builders;
  remove old secretChanged/updateIndexerConfFiles/RestartSplunk block
- pkg/splunk/enterprise/clustermanager.go: use extended init container
  command when ConfigMap has queue config keys
- pkg/splunk/enterprise/configuration.go: include queue config keys in
  smartstore volume Items when present
- pkg/splunk/enterprise/ingestorcluster.go: fix defaultMode:420 on
  ConfigMap volume and remove invalid install_source_checksum from
  local.meta
- test fixtures and test assertions updated accordingly

…er bundle push

Add a separate dedicated init container (init-cm-queue-config) on the ClusterManager pod
to symlink outputs.conf, inputs.conf, default-mode.conf from the new standalone CM queue
config ConfigMap (splunk-<cm>-clustermanager-queue-config) into manager-apps/splunk-operator/local/.

This init container is separate from the existing smartstore 'init' container — it only
runs when the queue config ConfigMap exists, does not touch any smartstore volume or Items
list, and avoids the Init:0/1 failure that occurred when mixing queue config into the
smartstore ConfigMap.

Changes:
- names.go: add cmQueueConfigMapTemplateStr constant, GetCMQueueConfigMapName() function
- clustermanager.go: add setupCMQueueConfigInitContainer(), call from getClusterManagerStatefulSet
- indexercluster.go: applyIdxcQueueConfigToCM now writes to GetCMQueueConfigMapName() instead of
  smartstore ConfigMap — fully decoupled, owned by ClusterManager CR
- util.go: resetSymbolicLinks removes stale setSymbolicLinkCmanagerWithQueue reference;
  adds queue config symlink reset after smartstore symlinks when CM queue config CM exists
- clustermanager_test.go: update Get call counts (+1 per reconcile for queue config CM lookup)

…orcluster

Extract applyQueueConfigMap, buildQueueConfStanza, generateQueueConfigAppConf,
and generateQueueConfigLocalMeta as package-level shared helpers so both
IngestorCluster and ClusterManager (IndexerCluster bundle push) use the same
implementation without duplication.

Changes:
- ingestorcluster.go: extract applyQueueConfigMap (idempotent CM apply with
  owner ref), buildQueueConfStanza (INI stanza builder), generateQueueConfigAppConf
  (parameterized label), generateQueueConfigLocalMeta (shared local.meta)
- buildAndApplyIngestorQueueConfigMap: simplified to call shared helpers
- generateIngestorOutputsConf: simplified to call buildQueueConfStanza
- computeIngestorConfChecksum and generateIngestorLocalMeta(checksum) removed
  (local.meta no longer embeds a checksum — simpler and avoids invalid field)
- ingestorcluster_test.go: update TestGenerateIngestorAppConf and
  TestGenerateIngestorLocalMeta to call shared function names

…vent reconcile loop

Omitting DefaultMode on ConfigMapVolumeSource caused MergePodUpdates to see
a volume diff on every reconcile (k8s stores defaultMode:420 but revised spec
had nil), triggering an infinite StatefulSet update and CM pod recycle loop.

…th C4 architecture diagram

- Rewrote doc with what-are-ingestors concept intro, full CR reference tables,
  and a step-by-step critical user journey (IAM -> Queue -> ObjectStorage ->
  IngestorCluster -> IndexerCluster -> verify data flow)
- Added Day-2 operations (scaling, credential rotation, pause, deletion order)
  and troubleshooting section
- Added C4 Container diagram rendered as PNG with Google-style muted
  Material Design colour palette